Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.fluent-logger: relax version for msgpack #98549

Merged
merged 1 commit into from Sep 23, 2020
Merged

[20.09] python3Packages.fluent-logger: relax version for msgpack #98549

merged 1 commit into from Sep 23, 2020

Conversation

freezeboy
Copy link
Contributor

Also add imports tests as we can't do more using the pip release

(cherry picked from commit e3c1b87)

Motivation for this change

Initial PR: #98211
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
python3Packages.fluent-logger: relax version for msgpack
fbf1226 
Also add imports tests as we can't do more using the pip release

(cherry picked from commit e3c1b87)
@jonringer jonringer merged commit a6b6b86 into NixOS:release-20.09 Sep 23, 2020
@freezeboy freezeboy deleted the backport-fluent-logger branch September 23, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @jonringer