Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/codimd: add option environmentFile for injecting secrets #98550

Merged
merged 1 commit into from Sep 23, 2020
Merged

nixos/codimd: add option environmentFile for injecting secrets #98550

merged 1 commit into from Sep 23, 2020

Conversation

WilliButz
Copy link
Member

Motivation for this change

Currently the upstream module is missing a way to pass secrets to the service without adding them to the Nix store.

Things done

Secrets are injected from the environment into the rendered
configuration before each startup using envsubst.
The test now makes use of this feature for the db password.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz
nixos/codimd: add option environmentFile for injecting secrets
403c215 
Secrets are injected from the environment into the rendered
configuration before each startup using envsubst.
The test now makes use of this feature for the db password.
@WilliButz WilliButz requested a review from Ma27 September 23, 2020 10:17
@WilliButz
Copy link
Member Author

@GrahamcOfBorg test codimd

@Ma27 Ma27 merged commit 8bcc2ba into NixOS:master Sep 23, 2020
@WilliButz WilliButz deleted the codimd/environment-secrets branch September 27, 2020 21:41
@elseym elseym mentioned this pull request Oct 7, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WilliButz @Ma27