Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm_11: 11.0.0rc2 -> 11.0.0rc5 #98594

Merged
merged 2 commits into from Oct 4, 2020
Merged

llvm_11: 11.0.0rc2 -> 11.0.0rc5 #98594

merged 2 commits into from Oct 4, 2020

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Sep 23, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review pr 98594"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from dtzWill and 7c6f434c September 23, 2020 22:06
@ggreif
Copy link
Contributor Author

ggreif commented Sep 23, 2020 •
edited

@GrahamcOfBorg build clang_11 lldb_11 lld_11

@ggreif ggreif marked this pull request as ready for review September 24, 2020 20:08
@ggreif ggreif changed the title llvm_11: 11.0.0rc2 -> 11.0.0rc3 llvm_11: 11.0.0rc2 -> 11.0.0rc5 Sep 30, 2020
@ggreif
Copy link
Contributor Author

ggreif commented Oct 1, 2020

@DieGoldeneEnte may I ask you to run nix-shell -p nix-review --run "nix-review pr 98594 on linux? Not too urgent, because the final is not out yet.

@DieGoldeneEnte
Copy link
Contributor

I actually just wanted to take a look at llvm11, since it should be out soon :)
nix-review only failed on faustlive (foo-yc20, purePackages.faust), but it uses llvm9 so we are not the reason (the others depend on faustlive).
So this should be good.

primeos
primeos approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ggreif and @DieGoldeneEnte! :)

@primeos primeos merged commit 6ab135d into NixOS:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggreif @DieGoldeneEnte @primeos