Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/test-driver: unrevert logging changes #98562

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

nixos/test-driver: unrevert logging changes #98562

wants to merge 3 commits into from

Conversation

JJJollyjim
Copy link
Member

Motivation for this change

Hi all

I tried to clean up the mess from #96699 :(

@ofborg test initrd-network-ssh ipv6

cc @Mic92 @andersk @worldofpeace

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Sep 23, 2020
View reviewed changes
nixos/lib/testing-python.nix
mkdir -p $out/coverage-data
mv $i $out/coverage-data/$(dirname $(dirname $i))
done
>>>>>>> parent of 59b6664f15c... Revert "Merge pull request #96254 from Mic92/logging"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be here:

worldofpeace
worldofpeace suggested changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@SuperSandro2000
Copy link
Member

@JJJollyjim ping

@JJJollyjim
Copy link
Member Author

@SuperSandro2000 I have given up on contributing to nixpkgs, sorry

@SuperSandro2000
Copy link
Member

@Mic92 Do you think this is still relevant?

@Mic92
Copy link
Member

Mic92 commented Jan 19, 2021

It is.

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank marked this pull request as draft March 25, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@worldofpeace worldofpeace worldofpeace requested changes

@tfc tfc Awaiting requested review from tfc tfc is a code owner

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JJJollyjim @SuperSandro2000 @Mic92 @worldofpeace @wegank