Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qrcp: renamed from qr-filetransfer, unstable-2018-10-22 -> 0.6.4 #98494

Merged
merged 1 commit into from Dec 21, 2020
Merged

qrcp: renamed from qr-filetransfer, unstable-2018-10-22 -> 0.6.4 #98494

merged 1 commit into from Dec 21, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Sep 22, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit September 22, 2020 20:55
@fgaz fgaz force-pushed the qrcp/0.6.4 branch 2 times, most recently from 8b496d5 to 885816d Compare September 23, 2020 08:34
@fgaz
Copy link
Member Author

fgaz commented Nov 21, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 21, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 26, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@fgaz
Copy link
Member Author

fgaz commented Nov 26, 2020

/status awaiting_changes

@fgaz
Copy link
Member Author

fgaz commented Dec 2, 2020

Rebased.

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 8, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@NixOS NixOS deleted a comment from marvin-mk2 bot Dec 11, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 14, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@fgaz
Copy link
Member Author

fgaz commented Dec 14, 2020

/status awaiting_changes

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 17, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

1 similar comment
@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 21, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 98494 run on x86_64-darwin 1

1 package built:
  • qrcp

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 98494 run on x86_64-linux 1

1 package built:
  • qrcp

@SuperSandro2000 SuperSandro2000 merged commit ff234e9 into NixOS:master Dec 21, 2020
@fgaz fgaz deleted the qrcp/0.6.4 branch December 21, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fgaz @SuperSandro2000