New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/gnome3: don't enable modules for excludePackages #98510
Conversation
These are confusing options since for these specific programs using |
I think it actually belongs in gnome3 module since that is what enables it, and the program modules should probably be independent of gnome3, and some people might use them separately. I don't think anyone is relying on the silent ignoring of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make your PR title the same as the commit message?
Maybe we should have integration testing for excludePackages. I wouldn't require it in this PR because our tests for gnome aren't that great. |
6a7b076
to
bc970e9
Compare
Sorry about that, it seems what I said could easily been interpreted the other way around. Module changes should have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested in a gnome vm with
environment.gnome3.excludePackages = [
pkgs.gnome3.geary
];
and verified that geary wasn't included in the installed system.
Oh that makes sense. I was confused by GitHub UI I couldn't tell what the suggested review actually was. It doesn't explicitly show in the files/review tab when there is commit message amendment I think. |
backported in 3c4e4be |
Thanks! I didn't want to overcomplicate it, maybe there will be a more general approach to this kind of situation at some point. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Motivation for this change
#24667
some packages disabled through environment.gnome3.excludePackages end up enabled anyways by their program module.
example:
Things done
Enable program module by default only if it's corresponding program is not listed in "excludedPackages"
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)