[LayoutNG] Make paint of OOF nodes relative to the fragmentainer #25734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 23, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2386382
branch
from
7e678a8
to
6d45447
Compare
When in a fragmentation context, there was this bug where an OOF node position did not appear to be relative to the fragmentainer ancestor. This was only a paint issue. This CL fixes it. Bug: 1113911 Change-Id: Ic9a4e5bab3a22fe3c25228cbbd2efec52ed1742a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386382 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#810316}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2386382
branch
from
6d45447
to
20fa3e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in a fragmentation context, there was this bug where an OOF node
position did not appear to be relative to the fragmentainer ancestor.
This was only a paint issue. This CL fixes it.
Bug: 1113911
Change-Id: Ic9a4e5bab3a22fe3c25228cbbd2efec52ed1742a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386382
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#810316}