Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim-plugins: onehalf - fix path #98597

Merged
merged 1 commit into from Mar 30, 2021
Merged

vim-plugins: onehalf - fix path #98597

merged 1 commit into from Mar 30, 2021

Conversation

onsails
Copy link
Contributor

@onsails onsails commented Sep 23, 2020 •
edited

Motivation for this change

Currently plugin is not being loaded because it's located in a vim subdir of a git repository.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@onsails onsails marked this pull request as draft October 1, 2020 17:38
@onsails onsails marked this pull request as ready for review October 1, 2020 17:44
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/434

@SuperSandro2000
Copy link
Member

@onsails is this still relevant?

@onsails
Copy link
Contributor Author

onsails commented Mar 27, 2021

@onsails is this still relevant?

yep, merge conflict is solved

@SuperSandro2000 SuperSandro2000 merged commit 2e1c5b6 into NixOS:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onsails @nixos-discourse @SuperSandro2000