New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ponyc: update 0.38.1 #98598
ponyc: update 0.38.1 #98598
Conversation
I can confirm that this build works (still on NixOS though) |
Marking as WIP as upstream has an emergency release this weekend. Will remove WIP and increment when the new release occurs (provisionally 0.38.1) |
77af63b
to
e24de09
Compare
e24de09
to
795a9b2
Compare
Emergency Release as mentioned above. Fixes a double-free bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on x86_64-darwin
795a9b2
to
f8f24e9
Compare
Oh, that's some great solutions - I'll implement and test them now. Thank you so much for your help thus far! |
I'm having problems with the substituteAll suggestion - getting
Line 38: is the first line in:
I guess I don't know where it should go? |
I think you'll need to use the substituteAll as the expression instead of the original patch? As is it seems like the parse error is coming up because it's just a free-floating expression in the middle of your record |
I'm looking through examples in nixpkgs and I think you're right. Lemme try that in patches... |
Okay - got it. Testing and pushing |
f8f24e9
to
59c9e1c
Compare
@veprbl - Re-requested a review as I've applied all suggested improvements. Is there anything else you need from me? |
59c9e1c
to
2141794
Compare
@veprbl - this commit should be interesting as I applied all your changes and re-pushed... but the build hash didn't change. I am both surprised and impressed that s/clangStdenv/stdenv/ in the .nix file and adding stdenv = clangStdenv as an override in all-packages resulted in the same output! |
@NixOS/ofborg |
@GrahamcOfBorg eval @redvers The s/clangStdenv/stdenv/ is just a variable rename, it does not change the computed derivation, so should not be too surprising. But I agree, it is quite nice, how it works. |
@veprbl - it's still failing, even though that commit to maintainers was reverted. I guess I can change a comment in a patch or something to force a new hash to force it to calculate? |
2141794
to
cc68f84
Compare
Success! |
Was able to build this as an overlay on MacOS 👍 |
@GrahamcOfBorg build ponyc pony-stable |
@veprbl - I have no idea why this is still executing after 6 hours. All the logs appear to be complete. |
Our darwin builder is offline right now. I don't know why the "Wait for ofborg" status still hasn't cleared. |
This addresses #98376
Motivation for this change
ponyc had been stalled at v0.33.2 for a while for three reasons:
I believe I have finally tamed this beast.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Note - I do not own a Mac so I'm going to be reliant on hydra to test against that platform.
Thanks!
(This is a redo of #98568 after I squashed that commit into a mess of 7 commits I couldn't fix - my apologies).
cc: @evanjs