Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.ihatemoney: disable sandbox unfriendly tests, fix passthru #98585

Merged
merged 1 commit into from Sep 23, 2020
Merged

[20.09] python3Packages.ihatemoney: disable sandbox unfriendly tests, fix passthru #98585

merged 1 commit into from Sep 23, 2020

Conversation

wkral
Copy link
Contributor

@wkral wkral commented Sep 23, 2020

(cherry picked from commit 43d588b)

Motivation for this change

Noticed this was fixed in master already and should makes a few packages and tests green in 20.09.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wkral
Copy link
Contributor Author

wkral commented Sep 23, 2020

Result of nixpkgs-review pr 98585 1

2 packages built:
  • python37Packages.ihatemoney
  • python38Packages.ihatemoney

@worldofpeace worldofpeace changed the base branch from release-20.09 to nixos-20.09 September 23, 2020 19:50
@worldofpeace worldofpeace changed the base branch from nixos-20.09 to release-20.09 September 23, 2020 19:51
@worldofpeace
Copy link
Contributor

Please don't mind that I changed the base branch to this PR, I just wanted to see that I couldn't merge to nixos-20.09 (unrelated to everything here).

@worldofpeace worldofpeace merged commit c8e389d into NixOS:release-20.09 Sep 23, 2020
@wkral
Copy link
Contributor Author

wkral commented Sep 23, 2020

@worldofpeace No worries, was slightly confused but it's all good :)

@wkral wkral deleted the backport-ihatemoney branch September 23, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wkral @worldofpeace @jonringer