Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ponyc: update to 0.37.0 #98568

Closed
wants to merge 6 commits into from
Closed

ponyc: update to 0.37.0 #98568

wants to merge 6 commits into from

Conversation

redvers
Copy link
Member

@redvers redvers commented Sep 23, 2020

Motivation for this change

ponyc had been stalled at v0.33.2 for a while for three reasons:

  1. The buildsystem had been changed from make to cmake
  2. A bug was discovered in LLVM 9.x which caused SIGSEGV in the test suite. The fix has been applied to LLVM upstream but is in the 10.x and master branch. Since ponyc currently uses 9.x, the build requires a patched+fixed llvm for the build only
  3. The additional complexity of the (temporary) build-system in use was a real pain to integrate into a nix package.

I believe I have finally tamed this beast.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Note - I do not own a Mac so I'm going to be reliant on hydra to test against that platform.

Thanks!

@evanjs
Copy link
Member

evanjs commented Sep 23, 2020

Is there any way we can use the already in-tree expressions for gtest/gbenchmark?
Not sure if optimal for this case, but I wonder if it would simplify these changes, any.

@redvers
Copy link
Member Author

redvers commented Sep 23, 2020

Is there any way we can use the already in-tree expressions for gtest/gbenchmark?
Not sure if optimal for this case, but I wonder if it would simplify these changes, any.

I actually tried that originally as I wanted to reduce the amount of work I had to do. I was not successful in pulling it in successfully. That very well may be due to my lack of knowledge of cmake, but I spent several hours in the attempt.

I consoled myself by reminding myself that it never exits the build process.

@ofborg ofborg bot requested a review from kamilchm September 23, 2020 15:42
@redvers redvers mentioned this pull request Sep 23, 2020
Closed
@redvers
Copy link
Member Author

redvers commented Sep 23, 2020

Reference #98376

@redvers
Copy link
Member Author

redvers commented Sep 23, 2020

While attempting to rebase I made a mess. Will open a new PR.

@redvers redvers closed this Sep 23, 2020
@redvers redvers deleted the ponyc_update branch September 23, 2020 20:12
@redvers redvers mentioned this pull request Sep 23, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchm kamilchm Awaiting requested review from kamilchm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@redvers @evanjs