Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tty-share: init at 2.0.0 #98558

Merged
merged 2 commits into from Dec 20, 2020
Merged

tty-share: init at 2.0.0 #98558

merged 2 commits into from Dec 20, 2020

Conversation

andys8
Copy link
Member

@andys8 andys8 commented Sep 23, 2020

Add tty-share - a tool to share tty sessions via webbrowser.

Motivation for this change

Add a missing tool

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

doronbehar
doronbehar reviewed Dec 18, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make the commit message:

tty-share: init at 0.6.2

pkgs/applications/misc/tty-share/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/tty-share/default.nix Show resolved Hide resolved
pkgs/applications/misc/tty-share/default.nix Outdated Show resolved Hide resolved
@andys8 andys8 force-pushed the add-tty-share branch 2 times, most recently from 4cc1bc5 to 03f7ad8 Compare December 18, 2020 20:10
@andys8
Copy link
Member Author

andys8 commented Dec 18, 2020

Rebased, added the suggestions, changed the commit messages and updated from 0.6.2 to 2.0.0.

@andys8 andys8 changed the title tty-share: Initial release with v0.6.2 tty-share: Initial release with 2.0.0 Dec 18, 2020
andys8 added a commit to andys8/dotfiles that referenced this pull request Dec 18, 2020
@andys8
Bump tty-share to 2.0.0
2f321fc 
See <NixOS/nixpkgs#98558>
@doronbehar doronbehar changed the title tty-share: Initial release with 2.0.0 tty-share: init at 2.0.0 Dec 19, 2020
doronbehar
doronbehar requested changes Dec 19, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your PR should have eventually two commits:

maintainers: add <me>
<package-name>: init at <version>

pkgs/applications/misc/tty-share/default.nix Outdated Show resolved Hide resolved
@andys8 andys8 force-pushed the add-tty-share branch 2 times, most recently from 7cb2c65 to 69c06f2 Compare December 19, 2020 10:27
doronbehar
doronbehar requested changes Dec 19, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 98558 run on x86_64-linux 1

1 package built:
  • tty-share

doronbehar
doronbehar approved these changes Dec 20, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI seems functional.

@doronbehar doronbehar merged commit a55a89c into NixOS:master Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andys8 @doronbehar