Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sundials: assert that lapack and blas are compatible #98500

Merged
merged 1 commit into from Dec 6, 2020
Merged

sundials: assert that lapack and blas are compatible #98500

merged 1 commit into from Dec 6, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Sep 22, 2020 •
edited

Instead of asserting that lapack and blas are both not using 64 bit index size, only make sure they are index size compatible. Plus, do it when evaluating buildInputs, per: #94892 (comment)

Don't pass SUNDIALS_INDEX_TYPE=int32_t if blas && lapack are compiled
with 64 bit index size.

Bonus: Use checkTarget and not an overrided checkPhase, per:
https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/explicit-phases.md

Motivation for this change

Implement stuff I learned at https://savannah.gnu.org/bugs/?57591#comment112

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli removed their request for review September 23, 2020 09:57
@doronbehar doronbehar mentioned this pull request Oct 1, 2020
Merged
10 tasks
@doronbehar doronbehar mentioned this pull request Dec 4, 2020
Closed
@doronbehar
sundials: assert that lapack and blas are compatible
16a0127 
Instead of asserting that lapack and blas are both not using 64 bit
index size, only make sure they are index size compatible. Plus, do it
when evaluating buildInputs, per:
NixOS#94892 (comment)

Don't pass SUNDIALS_INDEX_TYPE=int32_t if blas && lapack are compiled
with 64 bit index size.

Bonus: Use checkTarget and not an overrided checkPhase, per:
https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/explicit-phases.md
@GuillaumeDesforges
Copy link
Contributor

LGTM

Please note that I am no specialist of sundials (and no longer use it (have I ever? oh right it was a dependency for some Haskell lib)).
IMO @idontgetoutmuch is still the maintainer and should approve this.

@idontgetoutmuch
Copy link
Contributor

LGTM

@doronbehar
Copy link
Contributor Author

Thanks.

@doronbehar doronbehar merged commit 336fd62 into NixOS:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idontgetoutmuch idontgetoutmuch idontgetoutmuch approved these changes

@GuillaumeDesforges GuillaumeDesforges Awaiting requested review from GuillaumeDesforges

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @GuillaumeDesforges @idontgetoutmuch