New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qrupdate: refactor, and assert blas && lapack compatibility #98499
Conversation
The build won't fail without it, but it's needed according to: https://sourceforge.net/p/qrupdate/code/HEAD/tree/test/report_results
79c8259
to
2c6a444
Compare
Yea that would have been nicer, but apparently the flags are not passed to ld:
Though it does work if I use |
2c6a444
to
02f3784
Compare
Also please do not ping people in commit messages, that causes them to be notified every time the commit is rebased. It is better to ping in PRs and just use names without @ sign in the commit message. |
02f3784
to
0500d47
Compare
0500d47
to
dab4aac
Compare
Use `pname` and `version`. Use my preferred indentation style. Use makeFlagsArray in preBuild instead of overriding configurePhase, per: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/explicit-phases.md Assert that lapack and blas are compatible regarding 64 bit indexing, do it near evaluation of preBuild, per jtojnar's explanation: NixOS#94892 (comment) Use gpl3Plus, as gpl3 is unclear and deprecated.
dab4aac
to
8109377
Compare
@jtojnar is everything good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay.
Apparently, undetected in NixOS#98499, trying to use the flags written makes the build fail due to -O3.
Motivation for this change
Implement in Nix code stuff I learned at https://savannah.gnu.org/bugs/?57591 .
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)