Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tensorflow-bin_2: 2.1.0 -> 2.3.0 #98522

Closed
wants to merge 6 commits into from
Closed

tensorflow-bin_2: 2.1.0 -> 2.3.0 #98522

wants to merge 6 commits into from

Conversation

mkg20001
Copy link
Member

Motivation for this change

After #95824 (tensorflow-build_2 upgrade) tensorflow-bin_2 should be upgraded aswell

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mkg20001 mkg20001 mentioned this pull request Sep 23, 2020
Merged
10 tasks
eadwu
eadwu suggested changes Sep 23, 2020
View reviewed changes
Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tensorflow 2.3.0 supports Python 3.8

@mkg20001 mkg20001 mentioned this pull request Oct 1, 2020
Closed
10 tasks
@ofborg ofborg bot requested review from abbradar and cdepillabout October 1, 2020 16:38
@mkg20001
Copy link
Member Author

mkg20001 commented Oct 2, 2020

Currently broken because of a numpy version issue, need to fix that

@mkg20001
Copy link
Member Author

mkg20001 commented Oct 3, 2020 

    # TODO(mihaimaruseac): numpy 1.19.0 has ABI breakage
    # https://github.com/numpy/numpy/pull/15355

PR seems merged, not sure but possibly fixed in the next tensorflow release

Only other option is a revert

@SuperSandro2000
Copy link
Member

Verison in master is already newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eadwu eadwu eadwu requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@abbradar abbradar Awaiting requested review from abbradar

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkg20001 @SuperSandro2000 @eadwu @jyp