Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpxsee: 7.31 -> 7.32 #98533

Merged
merged 1 commit into from Sep 27, 2020
Merged

gpxsee: 7.31 -> 7.32 #98533

merged 1 commit into from Sep 27, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Sep 23, 2020 •
edited

Motivation for this change

Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from womfoo September 23, 2020 07:31
@rapenne-s
Copy link
Member

rapenne-s commented Sep 26, 2020 •
edited

Build and works fine on NixOS amd64.
I have a French locale and the localization is fine.

From my really small experience into Nixpkgs, the changes looks good.

@bjornfor bjornfor merged commit a502146 into NixOS:master Sep 27, 2020
@sikmir sikmir deleted the gpxsee branch September 27, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@womfoo womfoo Awaiting requested review from womfoo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @rapenne-s @bjornfor