New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.gym: fix dependency constraints #98591
Conversation
Result of 1 package failed to build:
5 packages built:
|
/marvin opt-in |
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
/status needs_reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
''; | ||
# cloudpickle range has been expanded in package but not yet released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future PRs, I think it would be better to have the comment before the thing you're commenting on. At least that seems to be the standard. Not important enough to hold this up though.
Motivation for this change
Found
cloudpickle
dependency has been expanded in openai/gym#2032 and tests are passing without any changes.ZHF: #97479
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)