Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] nixosTests.magnetico: wait for open port and make curl actually fail #98574

Merged
merged 1 commit into from Sep 23, 2020
Merged

[20.09] nixosTests.magnetico: wait for open port and make curl actually fail #98574

merged 1 commit into from Sep 23, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

ZHF #97479
Backport #98244

(cherry picked from commit 76aeb20)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj merged commit 9eb814f into NixOS:release-20.09 Sep 23, 2020
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Sep 23, 2020

Thank you

@mweinelt mweinelt deleted the 20.09/nixos/tests/magnetico branch September 23, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @rnhmjoj