Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 7fab0b1c1acf
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: ecc00bd8f632
Choose a head ref
  • 7 commits
  • 4 files changed
  • 2 contributors

Commits on Sep 21, 2020

  1. lib/types: Remove unreachable if branch 

    The type's check function already ensured that it can't be passed
non-lists
    @infinisil
    infinisil committed Sep 21, 2020
    Copy the full SHA
    2ff7c3e View commit details
    Browse the repository at this point in the history

  2. lib/options: Introduce showDefs 

    For pretty-printing definitions, including file and values
    @infinisil
    infinisil committed Sep 21, 2020
    Copy the full SHA
    7c20e68 View commit details
    Browse the repository at this point in the history

  3. lib/modules: Improve error messages using showDefs

    @infinisil
    infinisil committed Sep 21, 2020
    Copy the full SHA
    bdfcee2 View commit details
    Browse the repository at this point in the history

  4. lib/modules: Evaluate single defs for readOnly error 

    If multiple definitions are passed, this evaluates them all as if they
were the only one, for a better error message. In particular this won't
show module-internal properties like `_type = "override"` and co.
    @infinisil
    infinisil committed Sep 21, 2020
    Copy the full SHA
    910dfdc View commit details
    Browse the repository at this point in the history

  5. lib/tests: Allow grepping for newlines in error messages

    @infinisil
    infinisil committed Sep 21, 2020
    Copy the full SHA
    4f0982b View commit details
    Browse the repository at this point in the history

  6. lib/tests: Update for error message changes

    @infinisil
    infinisil committed Sep 21, 2020
    Copy the full SHA
    8908766 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Merge pull request #98155 from Infinisil/improved-module-errors 

    Improved module errors
    @edolstra
    edolstra committed Sep 23, 2020
    Copy the full SHA
    ecc00bd View commit details
    Browse the repository at this point in the history