Adding Lenovo Thinkpad E470 #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 24, 2020
|
I also added a note in the README to also link the file in flake.nix |
Mic92
reviewed
Sep 28, 2020
lenovo/thinkpad/e470/default.nix
Outdated
| nvidiaBusId = lib.mkDefault "PCI:1:0:0"; | ||
| }; | ||
|
|
||
| boot.kernelPackages = pkgs.linuxPackages_latest; |
There was a problem hiding this comment.
Is there a minimum kernel version that we need? At some point it would be nice to unpin this line. Please leave a comment which kernel version you need as lower bound.
There was a problem hiding this comment.
Maybe something like this helps:
boot.kernelPackages = lib.mkIf (lib.versionOlder pkgs.linux.version "5.6") pkgs.linuxPackages_latest;
|
Could this be merged? 😅 |
|
Thanks for the chase up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.