Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests.haskell-shellFor: get compiling again [backport to 20.09] #98518

Merged
merged 1 commit into from Sep 23, 2020
Merged

tests.haskell-shellFor: get compiling again [backport to 20.09] #98518

merged 1 commit into from Sep 23, 2020

Conversation

cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Sep 23, 2020 •
edited

Motivation for this change

Backport of #98459 to the 20.09 release branch.

(cherry picked from commit bdc7dee)

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build tests.haskell-shellFor

jonringer
jonringer approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98518 1

1 package built:
  • tests.haskell-shellFor

@jonringer jonringer merged commit aa37cc1 into NixOS:release-20.09 Sep 23, 2020
@cdepillabout cdepillabout deleted the backport_tests.haskell-shellFor branch September 23, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdepillabout @jonringer