Migrate isInputPending options class to dictionary #25702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 23, 2020
Updates the API for isInputPending and associated tests to accept a dictionary object for parameterization directly, making it compliant with the updated spec. Bug: 910421 Change-Id: I39e569ee6215044a9b59a8834d19cac76915cb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425138 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#810490}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2425138
branch
from
aca451d
to
71473ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the API for isInputPending and associated tests to accept a dictionary
object for parameterization directly, making it compliant with the updated
spec.
Bug: 910421
Change-Id: I39e569ee6215044a9b59a8834d19cac76915cb9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425138
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#810490}