Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs: 0.6.0 -> 0.7.0 #98554

Merged
merged 3 commits into from Sep 24, 2020
Merged

ipfs: 0.6.0 -> 0.7.0 #98554

merged 3 commits into from Sep 24, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Sep 23, 2020

Motivation for this change

https://github.com/ipfs/go-ipfs/releases/tag/v0.7.0

Pinning go114 is no longer necessary with this version.
Also fix a warning because of the system units being executable and a warning during the build because mv tried to move a directory into itself.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Luflosi
ipfs: remove executable bit from systemd units
1a382e9 
IPFS would complain with warnings like
Configuration file /nix/store/...-ipfs-0.6.0/etc/systemd/system/ipfs.service is marked executable. Please remove executable permission bits. Proceeding anyway.
@Luflosi
ipfs: avoid warning during build when moving directory
d385065 
Trying to move a directory into itself will result in a warning:
mv: cannot move 'ipfs-src' to a subdirectory of itself, 'ipfs-src/ipfs-src'

This can be prevented by excluding that directory.
@Luflosi
ipfs: 0.6.0 -> 0.7.0
b75e431 
https://github.com/ipfs/go-ipfs/releases/tag/v0.7.0

Pinning go114 is no longer necessary with this version.
@ofborg ofborg bot requested review from kalbasit and fpletz September 23, 2020 11:51
@zimbatm
Copy link
Member

zimbatm commented Sep 24, 2020

Result of nixpkgs-review pr 98554 1

1 package built:
  • ipfs

@zimbatm zimbatm merged commit f32bc5c into NixOS:master Sep 24, 2020
@Luflosi Luflosi deleted the update/ipfs branch September 24, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luflosi @zimbatm