Use allow attribute for delegation in web serial WPT #25713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 23, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2424655
branch
from
964a925
to
0b4fb6b
Compare
With an upcoming change to Feature/Permissions Policy, the header alone will no longer be sufficient to delegate permissions to use powerful features in subframes. The iframe allow attribute must be used in conjunction with it. The header can still be used to block delegation. This change updates the WebSerial WPTs to use the allow attribute for delegation. Bug: 1095641 Change-Id: I810cd5df06b89b0b5b2f2c160e0f9eac19dd67f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424655 Commit-Queue: Ian Clelland <iclelland@chromium.org> Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#809834}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2424655
branch
from
0b4fb6b
to
fe21bd0
Compare
|
Unclear if caused by this change but the test is running pretty close to the long timeout, so added a meta tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an upcoming change to Feature/Permissions Policy, the header
alone will no longer be sufficient to delegate permissions to use
powerful features in subframes. The iframe allow attribute must
be used in conjunction with it. The header can still be used to
block delegation.
This change updates the WebSerial WPTs to use the allow attribute
for delegation.
Bug: 1095641
Change-Id: I810cd5df06b89b0b5b2f2c160e0f9eac19dd67f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424655
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Auto-Submit: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#809834}