Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.parse: 1.16.0 -> 1.18.0, python-docx: run behave tests #98569

Merged
merged 3 commits into from Sep 26, 2020
Merged

[20.09] python3Packages.parse: 1.16.0 -> 1.18.0, python-docx: run behave tests #98569

merged 3 commits into from Sep 26, 2020

Conversation

maxxk
Copy link
Contributor

@maxxk maxxk commented Sep 23, 2020

Backport of #97737
ZHF: #97479
cc @NixOS/nixos-release-managers

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nixpkgs-review results:

2 packages failed to build:
python38Packages.pytest-bdd terraform-compliance

18 packages built:
nrfutil python27Packages.parse python27Packages.parse-type python27Packages.pyparser python27Packages.pytest-bdd python37Packages.behave python37Packages.parse python37Packages.parse-type python37Packages.pyparser python37Packages.pytest-bdd python37Packages.python-docx python37Packages.radish-bdd python38Packages.behave python38Packages.parse python38Packages.parse-type python38Packages.pyparser python38Packages.python-docx python38Packages.radish-bdd

@ofborg ofborg bot requested a review from AJChapman September 23, 2020 15:57
@jonringer
Copy link
Contributor

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

the hashes are:

Since i did a rebase and merge, they were given new hashes on master

@maxxk
python3Packages.parse: 1.16.0 -> 1.18.0
5f19aca 
(cherry picked from commit 6543cbf)
@maxxk
python3Packages.python-docx: run behave tests
dc12a5a 
Previously the problematic "behave" dependency
was not even used at checkPhase.

(cherry picked from commit f690cac)
@maxxk
python3Packages.behave: skip test failing on darwin
1189b50 
Timing-based test is flaky on Darwin:
NixOS#97737 (comment)

(cherry picked from commit 0f34c4e)
@maxxk
Copy link
Contributor Author

maxxk commented Sep 23, 2020

Sorry, forgot about the rebase.

@risicle
Copy link
Contributor

risicle commented Sep 26, 2020

WFM non-nixos linux x86_64, macos 10.14.

@risicle risicle merged commit 40c9bae into NixOS:release-20.09 Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@AJChapman AJChapman Awaiting requested review from AJChapman

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxxk @jonringer @risicle