Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmod: add patch to correct behaviour with --field #96153

Merged
merged 1 commit into from Aug 28, 2020
Merged

kmod: add patch to correct behaviour with --field #96153

merged 1 commit into from Aug 28, 2020

Conversation

xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Aug 24, 2020 •
edited

#96123 targeted at staging

This came up in #96008.
Without this patch modinfo always prints the module name for builtin
modules, even if an explicit --field is passed.

(I also posted this patch upstream, waiting for feedback there)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xaverdh
kmod: add patch to correct behaviour with --field
40d3388 
This came up in NixOS#96008.
Without this patch modinfo always prints the module name for builtin
modules, even if an explicit --field is passed.
@FRidh FRidh mentioned this pull request Aug 24, 2020
Closed
10 tasks
@FRidh FRidh added this to WIP in Staging via automation Aug 24, 2020
@lheckemann
Copy link
Member

Upstream submission: https://lore.kernel.org/linux-modules/20200823215433.j5gc5rnsmahpf43v@blumerang/T/#u

@lheckemann lheckemann merged commit 4f4d0ca into NixOS:staging Aug 28, 2020
Staging automation moved this from WIP to Done Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xaverdh @lheckemann