Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cri-o: add NixOS test via critest #96096

Merged
merged 1 commit into from Aug 24, 2020
Merged

cri-o: add NixOS test via critest #96096

merged 1 commit into from Aug 24, 2020

Conversation

saschagrunert
Copy link
Member

Motivation for this change

Add a critest based test for the CRI-O module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq I assume it is not possible to have network access in the tests, right? Most of the tests required this.

@saschagrunert
Copy link
Member Author

@GrahamcOfBorg test cri-o

@saschagrunert
Copy link
Member Author

@GrahamcOfBorg test cri-o

@saschagrunert
Copy link
Member Author

Alright, the two basic runtime tests do not require networking and seem to succeed for now. PTAL @NixOS/podman

@zowoq
Copy link
Contributor

zowoq commented Aug 23, 2020

I've opened #96124 to add/update passthru.tests for crio/podman.

zowoq
zowoq reviewed Aug 24, 2020
View reviewed changes
nixos/tests/all-tests.nix Outdated Show resolved Hide resolved
@zowoq
Copy link
Contributor

zowoq commented Aug 24, 2020

I assume it is not possible to have network access in the tests, right? Most of the tests required this.

We could probably use skopeo to sideload containers so we can do something like the podman test but I think this is fine for now.

@saschagrunert
cri-o: add NixOS test via critest
bcbe116 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

I assume it is not possible to have network access in the tests, right? Most of the tests required this.

We could probably use skopeo to sideload containers so we can do something like the podman test but I think this is fine for now.

Yes, at least we test if the module is working and the runtime is reach-able 👍

@zowoq zowoq merged commit 1c551f9 into NixOS:master Aug 24, 2020
@saschagrunert saschagrunert deleted the cri-o-test branch August 24, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq left review comments

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschagrunert @zowoq