Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

katago: 1.5.0 -> 1.6.0 #96121

Merged
merged 1 commit into from Aug 25, 2020
Merged

katago: 1.5.0 -> 1.6.0 #96121

merged 1 commit into from Aug 25, 2020

Conversation

OmnipotentEntity
Copy link
Contributor

Motivation for this change

Update to the latest version. Add CPU only version of the engine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@OmnipotentEntity
Copy link
Contributor Author

I have not been able to successfully test the useAVX2 options. While it compiles fine, my computer does not support AVX2 instructions, so I simply get an illegal hardware instruction error. I left in the option in case users want to fiddle with the toggle, because it's exposed via CMake specifically to make Eigen less slow in the CPU only version.

rnhmjoj
rnhmjoj reviewed Aug 23, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -24383,6 +24383,11 @@ in
cudatoolkit = cudatoolkit_10_2;
};

katagoCPU = katago.override {
gpuEnabled = false;
eigen = eigen;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems useless...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The eigen = eigen part? Roger. I'll take it out. I know it's a no-op. I just thought it would make the dependency clearer to a reader.

@rnhmjoj rnhmjoj merged commit 8c48e50 into NixOS:master Aug 25, 2020
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Aug 25, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OmnipotentEntity @rnhmjoj