Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libseccomp: 2.4.3 -> 2.5.0 #96172

Merged
merged 3 commits into from Aug 25, 2020
Merged

libseccomp: 2.4.3 -> 2.5.0 #96172

merged 3 commits into from Aug 25, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 24, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@saschagrunert
Copy link
Member Author

cc @thoughtpolice

@saschagrunert
Copy link
Member Author

@GrahamcOfBorg build libseccomp

1 similar comment
@saschagrunert
Copy link
Member Author

@GrahamcOfBorg build libseccomp

@ofborg ofborg bot requested a review from thoughtpolice August 24, 2020 12:46
thoughtpolice
thoughtpolice requested changes Aug 24, 2020
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this on top of staging, not master.

@saschagrunert
libseccomp: format with nixpkgs-fmt
3829a40 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
libseccomp: 2.4.3 -> 2.5.0
33842ca 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
libseccomp: enable RISC-V architecture
ae3fe42 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert changed the base branch from master to staging August 24, 2020 17:16
@saschagrunert
Copy link
Member Author

Please rebase this on top of staging, not master.

Done. Thanks for the hint!

@ofborg ofborg bot requested a review from thoughtpolice August 24, 2020 18:17
@thoughtpolice thoughtpolice merged commit 7f76840 into NixOS:staging Aug 25, 2020
@thoughtpolice
Copy link
Member

Thanks!

@saschagrunert saschagrunert deleted the libseccomp branch August 25, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@andir andir Awaiting requested review from andir

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

@ttuegel ttuegel Awaiting requested review from ttuegel

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saschagrunert @thoughtpolice @JohnAZoidberg