Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.pelican: 4.2.0 -> 4.5.0 #96137

Merged
merged 1 commit into from Aug 24, 2020
Merged

python37Packages.pelican: 4.2.0 -> 4.5.0 #96137

merged 1 commit into from Aug 24, 2020

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Aug 24, 2020 •
edited

Motivation for this change

Bump to latest version.

This version drops support for Python 2.

See PR #87600 for discussion for backporting to nixos-20.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Moredread
python37Packages.pelican: 4.2.0 -> 4.5.0
27960ec 
This version drops support for Python 2.
@Moredread Moredread changed the title pelican: 4.2.0 -> 4.5.0 python37Packages.pelican: 4.2.0 -> 4.5.0 Aug 24, 2020
@ofborg ofborg bot requested review from offlinehacker and prikhi August 24, 2020 04:02
@mweinelt
Copy link
Member

Executed all binaries with --help. LGTM.

Result of nixpkgs-review pr 96137 1

2 packages built:
- python37Packages.pelican
- python38Packages.pelican

@mweinelt mweinelt merged commit d285ed1 into NixOS:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@prikhi prikhi Awaiting requested review from prikhi

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Moredread @mweinelt