Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harfbuzz: 2.6.7 → 2.7.1 #96105

Merged
merged 1 commit into from Aug 24, 2020
Merged

harfbuzz: 2.6.7 → 2.7.1 #96105

merged 1 commit into from Aug 24, 2020

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Aug 23, 2020 •
edited

Notable changes:

  • Upstream changed from freedesktop.org to GitHub, so updateWalker is disabled and fetchFromGitHub used
  • Build system now based on meson/ninja
  • python3 instead of python
  • postInstall hook moved to postFixup since it depends on some files being moved around in fixupPhase

Help testing this and feedback would be appreciated. I couldn't test it on darwin yet, for example, and I doubt a nixpkgs-review on my hardware will finish in a reasonable time.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build harfbuzz harfbuzzFull

jtojnar
jtojnar reviewed Aug 23, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay:

Meson migration guide too:

https://github.com/harfbuzz/harfbuzz/wiki/Notes-on-migration-to-meson

pkgs/development/libraries/harfbuzz/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/harfbuzz/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/harfbuzz/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/harfbuzz/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/harfbuzz/default.nix Outdated Show resolved Hide resolved
@sternenseemann sternenseemann force-pushed the harfbuzz-2.7.1 branch 3 times, most recently from 3a1eb73 to d9797a5 Compare August 23, 2020 19:33
@sternenseemann sternenseemann force-pushed the harfbuzz-2.7.1 branch 2 times, most recently from 613304e to 1171e09 Compare August 23, 2020 21:06
@sternenseemann
harfbuzz: 2.6.7 → 2.7.1
820b5f1 
* Upstream changed from freedesktop.org to GitHub,
  so updateWalker is disabled and fetchFromGitHub used
* Build system now based on meson/ninja
* python3 instead of python
* postInstall hook moved to postFixup since it depends on
  some files being moved around in fixupPhase
* Build developer manual using gtk-doc
@FRidh FRidh changed the base branch from master to staging August 24, 2020 09:57
@FRidh FRidh merged commit c9a7fdf into NixOS:staging Aug 24, 2020
@sternenseemann sternenseemann deleted the harfbuzz-2.7.1 branch August 24, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @jtojnar @FRidh