Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfce.xfce4-volumed: drop #96118

Merged
merged 1 commit into from Aug 23, 2020
Merged

xfce.xfce4-volumed: drop #96118

merged 1 commit into from Aug 23, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 23, 2020 •
edited

Motivation for this change

Unmaintained and broken.

cc @abbradar and #39975

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
xfce.xfce4-volumed: drop
2ff80c4 
Unmaintained and broken
@jtojnar jtojnar added this to To do in Picking up garbage via automation Aug 23, 2020
@jtojnar jtojnar added this to the 20.09 milestone Aug 23, 2020
@jtojnar jtojnar moved this from To do to In progress in Picking up garbage Aug 23, 2020
@worldofpeace worldofpeace merged commit 53e6945 into NixOS:master Aug 23, 2020
Picking up garbage automation moved this from In progress to Done Aug 23, 2020
@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 23, 2020 •
edited

Thanks @jtojnar

@jtojnar jtojnar deleted the xfce-volumed-drop branch August 23, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: xfce The Xfce Desktop Environment 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Picking up garbage
  
Done
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @worldofpeace