Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.test-tube: init at 0.7.5 #96119

Merged
merged 1 commit into from Aug 23, 2020
Merged

python3Packages.test-tube: init at 0.7.5 #96119

merged 1 commit into from Aug 23, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Aug 23, 2020 •
edited

Motivation for this change

Optional dependency of python3Packages.pytorch-lightning (finishes the refresh of #77155 started with #95827).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @tbenst

@bcdarwin bcdarwin mentioned this pull request Aug 23, 2020
Closed
10 tasks
@ofborg ofborg bot requested a review from tbenst August 23, 2020 23:05
jonringer
jonringer approved these changes Aug 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96119 1

2 packages built:
- python37Packages.test-tube
- python38Packages.test-tube

@jonringer jonringer merged commit 6fdfeda into NixOS:master Aug 23, 2020
@bcdarwin bcdarwin deleted the test-tube branch August 24, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@tbenst tbenst Awaiting requested review from tbenst

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @jonringer