Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGTK*: Remove abandoned dependencies #96120

Merged
merged 4 commits into from Sep 2, 2020
Merged

wxGTK*: Remove abandoned dependencies #96120

merged 4 commits into from Sep 2, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 23, 2020 •
edited

Motivation for this change

The many-years abandoned GStreamer 0.10 branch no longer builds so let's remove it. Hopefully nothing used it these days.

GConf has been abandoned for years too and would not work without user running the daemon.

cc #39975 #93540

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar changed the title Cleaner wx wxGTK*: Remove abandoned dependencies Aug 23, 2020
@jtojnar jtojnar added this to To do in Picking up garbage via automation Aug 23, 2020
@jtojnar jtojnar moved this from To do to In progress in Picking up garbage Aug 23, 2020
@jtojnar jtojnar added this to the 20.09 milestone Aug 23, 2020
@jtojnar
wxGTK28: drop ancient deps
55a7a01 
The many-years abandoned GStreamer 0.10 branch no longer builds so let's remove it. Hopefully nothing used it these days.

GConf has been abandoned for years too and would not work without user running the daemon.
@7c6f434c
Copy link
Member

Erm, this flat-out breaks the build, though? Are there some flags to pass?

@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 27, 2020 •
edited

At least 28 builds fine.

From the error message, it sounds like it revealed an underspecified dependency that was previously masked by propagation:

./vidxanm.cpp:23:10: fatal error: X11/Intrinsic.h: No such file or directory
   23 | #include <X11/Intrinsic.h>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.

Did not have time to look into it yet, though.

Edit: Looks like it does not affect the build.

@7c6f434c
Copy link
Member

One of the builds seems to complain explicitly about gstreamer not found, though.

@jtojnar
wxGTK29: drop ancient deps
6de7492 
The many-years abandoned GStreamer 0.10 branch no longer builds so let's remove it. Hopefully nothing used it these days.

GConf has been abandoned for years too and would not work without user running the daemon.
@jtojnar
wxGTK30-gtk2: drop ancient deps
e2d02a8 
GConf has been abandoned for many years and would not work without user running the daemon.
@jtojnar
wxGTK31-gtk2: drop ancient deps
2fd206f 
GConf has been abandoned for many years and would not work without user running the daemon.
@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 28, 2020

Seems to build now, after removing a configure flag.

@jtojnar jtojnar merged commit 8401161 into NixOS:master Sep 2, 2020
Picking up garbage automation moved this from In progress to Done Sep 2, 2020
@jtojnar jtojnar deleted the cleaner-wx branch September 2, 2020 00:06
@jtojnar
Copy link
Contributor Author

jtojnar commented Sep 2, 2020 •
edited

Let's see what it breaks (or rather reveals as broken).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
Picking up garbage
  
Done
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @7c6f434c