utf8proc: enable tests #96089
Merged
utf8proc: enable tests #96089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some projects (Fcitx) for instance check wether the file is available locally before downloading them from the Internet. Worth asking upstream to do the same. |
|
@teto I'm not even sure what |
jtojnar
reviewed
Aug 23, 2020
sternenseemann
force-pushed
the
utf8proc-tests
branch
from
f0368be
to
7f2b01c
Compare
For the current version normtest and graphemetest are disabled. This
will probably change in the future. Those tests are problematic because
they depend on unicode data files which are downloaded by cmake at build
time:
file(MAKE_DIRECTORY data)
set(UNICODE_VERSION 13.0.0)
file(DOWNLOAD https://www.unicode.org/Public/${UNICODE_VERSION}/ucd/NormalizationTest.txt data/NormalizationTest.txt SHOW_PROGRESS)
file(DOWNLOAD https://www.unicode.org/Public/${UNICODE_VERSION}/ucd/auxiliary/GraphemeBreakTest.txt data/GraphemeBreakTest.txt SHOW_PROGRESS)
For the next update, we'll probably need to patch out this section of
CMakeLists.txt and download the files in question with fetchurl
ourselves.
sternenseemann
force-pushed
the
utf8proc-tests
branch
from
7f2b01c
to
d9aed71
Compare
|
Rebased against master to fix merge conflict with #96087. |
teto
reviewed
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Enable test suite of
utf8proc.For the current version normtest and graphemetest are disabled. This
will probably change in the future. Those tests are problematic because
they depend on unicode data files which are downloaded by cmake at build
time:
For the next update, we'll probably need to patch out this section of
CMakeLists.txt and download the files in question with fetchurl
ourselves. It's trivial, but a little more maintenance work because
you have two more hashes to update.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)