Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] qtwebengine: fix build for darwin #96130

Merged
merged 1 commit into from Aug 24, 2020
Merged

[20.03] qtwebengine: fix build for darwin #96130

merged 1 commit into from Aug 24, 2020

Conversation

eqyiel
Copy link
Contributor

@eqyiel eqyiel commented Aug 24, 2020 •
edited

Motivation for this change

Port #95826 to stable.

(cherry picked from commit 68bf910

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    • I'm not sure how tell this command to use the release branch
  • Tested execution of all binary files (usually in ./result/bin/)
    • Not directly, but by packages that use it (like Anki)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eqyiel
qtwebengine: fix build for darwin
e5612eb 
(cherry picked from commit 68bf910)
@eqyiel eqyiel requested a review from ttuegel as a code owner August 24, 2020 00:34
@eqyiel eqyiel mentioned this pull request Aug 24, 2020
Merged
10 tasks
@veprbl
Copy link
Member

veprbl commented Aug 24, 2020

@GrahamcOfBorg build qt5.qtwebengine

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde labels Aug 24, 2020
@ofborg ofborg bot requested a review from matthewbauer August 24, 2020 02:07
@veprbl veprbl merged commit 14006b7 into NixOS:release-20.03 Aug 24, 2020
@veprbl
Copy link
Member

veprbl commented Aug 24, 2020

Thank you!

@eqyiel eqyiel deleted the fix/port-95826-to-stable branch August 24, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eqyiel @veprbl