Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/gnome3: start terminal with autostart file #96102

Merged
merged 1 commit into from Aug 23, 2020
Merged

nixos/tests/gnome3: start terminal with autostart file #96102

merged 1 commit into from Aug 23, 2020

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Aug 23, 2020

Motivation for this change

For some reason starting the terminal using su user -c '...' have
tendency to fail. Simply use an autostart file instead.

Haven't done massive testing, but before this change I had a bunch of local failures, and after it hasn't failed a single time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning
nixos/tests/gnome3: start terminal with autostart file
625d8be 
For some reason starting the terminal using `su user -c '...'` have
tendency to fail. Simply use an autostart file instead.
@hedning
Copy link
Contributor Author

hedning commented Aug 23, 2020

@GrahamcOfBorg test gnome3

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Aug 23, 2020
@hedning hedning merged commit 7aaf526 into NixOS:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hedning