Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.installer.btrfsSubvolDefault: fix warning #96094

Merged
merged 1 commit into from Aug 23, 2020
Merged

nixosTests.installer.btrfsSubvolDefault: fix warning #96094

merged 1 commit into from Aug 23, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Aug 23, 2020

Motivation for this change

Before:

machine: must succeed: btrfs subvol set-default $(btrfs subvol list /mnt | grep 'nixos' | awk '{print \$2}') /mnt
machine # awk: cmd. line:1: {print \$2}                                        
machine # awk: cmd. line:1:        ^ backslash not last character on line
machine # awk: cmd. line:1: {print \$2}                                                                                                                        
machine # awk: cmd. line:1:        ^ syntax error                              
machine # [   29.449275] BTRFS info (device vda3): setting incompat feature flag for DEFAULT_SUBVOL (0x2)

After:

machine: must succeed: btrfs subvol set-default $(btrfs subvol list /mnt | grep 'nixos' | awk '{print $2}') /mnt
machine # [   12.283682] BTRFS info (device vda3): setting incompat feature flag for DEFAULT_SUBVOL (0x2)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 requested a review from tfc August 23, 2020 14:10
@tfc
Copy link
Contributor

tfc commented Aug 23, 2020

thx!

@tfc
Copy link
Contributor

tfc commented Aug 23, 2020

@GrahamcOfBorg test installer.btrfsSubvolDefault

@tfc tfc merged commit 7e545bd into NixOS:master Aug 23, 2020
@ajs124 ajs124 deleted the fix/test/installer-btrfs-warning branch August 24, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc Awaiting requested review from tfc

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs124 @tfc