Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfkill: remove #96103

Merged
merged 1 commit into from Aug 24, 2020
Merged

rfkill: remove #96103

merged 1 commit into from Aug 24, 2020

Conversation

deviant
Copy link
Member

@deviant deviant commented Aug 23, 2020

Motivation for this change

rfkill was subsumed by util-linux in 2017 [1], and the upstream has not
been updated in over 5 years [2]. This package shadows the rfkill from
util-linux, so it can be completely removed with no breaking changes,
because util-linux is in the base package set in nixos/system-path.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Aug 23, 2020

Eval failed because we require that any in-tree packages can't reference the aliases, they must refer to the actual package (utillinux).

@veprbl veprbl requested a review from edolstra August 23, 2020 19:43
@deviant
Copy link
Member Author

deviant commented Aug 23, 2020

@veprbl blueberry was added very recently, I've been sitting on this patch for months and the new addition slipped past me. Will fix it later :-)

@deviant
rfkill: remove
b63b5ed 
rfkill was subsumed by util-linux in 2017 [1], and the upstream has not
been updated in over 5 years [2]. This package shadows the rfkill from
util-linux, so it can be completely removed with no breaking changes,
because util-linux is in the base package set in nixos/system-path.

[1] util-linux/util-linux@d17fb72
[2] https://git.sipsolutions.net/rfkill.git/log/
@deviant
Copy link
Member Author

deviant commented Aug 24, 2020

@veprbl Should be fixed now.

@ofborg ofborg bot requested a review from romildo August 24, 2020 02:19
romildo
romildo approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edolstra edolstra merged commit 63b8d53 into NixOS:master Aug 24, 2020
@deviant deviant deleted the remove-rfkill branch August 24, 2020 16:22
evanjs added a commit to evanjs/nixos_cfg that referenced this pull request Sep 8, 2020
@evanjs
hardware/profiles/wireless: remove rfkill
faa8fae 
rfkill is being removed as it was subsumed by util-linux in 2017

See NixOS/nixpkgs#96103 for more information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romildo romildo romildo approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deviant @veprbl @romildo @edolstra @Janik-Haag