Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart: 2.7.2 -> 2.10.4 (stable) + 2.9.0-4.0.dev -> 2.12.0-223.0.dev (dev) #96174

Closed
wants to merge 1 commit into from
Closed

dart: 2.7.2 -> 2.10.4 (stable) + 2.9.0-4.0.dev -> 2.12.0-223.0.dev (dev) #96174

wants to merge 1 commit into from

Conversation

Sorixelle
Copy link
Member

Motivation for this change
  • Update Dart stable to 2.9.1
  • Update Dart dev to 2.10.0-45.0.dev
  • Fix dartaotruntime binary not having it's interpreter and rpath patched
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Sorixelle Sorixelle changed the title dart: 2.7.2 -> 2.9.1 (stable) + 2.9.0-4.0.dev -> 2.10.0.45.0.dev (dev) dart: 2.7.2 -> 2.9.1 (stable) + 2.9.0-4.0.dev -> 2.10.0-45.0.dev (dev) Aug 24, 2020
@ofborg ofborg bot requested a review from GRBurst August 24, 2020 13:25
@ericdallo
Copy link
Member

@Mic92 could you help us merging this? thanks!

@Sorixelle
Copy link
Member Author

Sorixelle commented Aug 29, 2020 •
edited

Dart got a 2.9.2 update, should I do that in this PR or make a new one once this is merged?

@ericdallo
Copy link
Member

I'd rather bump in this PR :)

@Sorixelle Sorixelle changed the title dart: 2.7.2 -> 2.9.1 (stable) + 2.9.0-4.0.dev -> 2.10.0-45.0.dev (dev) dart: 2.7.2 -> 2.9.2 (stable) + 2.9.0-4.0.dev -> 2.10.0-59.0.dev (dev) Aug 30, 2020
@jtacoma
Copy link
Contributor

jtacoma commented Dec 29, 2020

Sorry, it looks like this conflicts with #105109, though I think that won't be too hard to fix. However, it also conflicts with #105311, which might be a neater solution here. I like what #105311 is going for, but it's going to require some adjustment for derivations that call dart/default.nix. What do you think?

@SuperSandro2000
Copy link
Member

@Sorixelle please fix the merge conflict.

@Sorixelle Sorixelle changed the title dart: 2.7.2 -> 2.9.2 (stable) + 2.9.0-4.0.dev -> 2.10.0-59.0.dev (dev) dart: 2.7.2 -> 2.10.4 (stable) + 2.9.0-4.0.dev -> 2.12.0-223.0.dev (dev) Jan 18, 2021
@Sorixelle
Copy link
Member Author

Merge conflict fixed, rebased, and versions updated to most recent versions. I agree with @jtacoma here - #105311 seems like a much better solution going forward. It seems a bit stagnant at the moment, so for now, I think we can merge this so we have up-to-date versions now, and look at getting the aforementioned PR going.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 96174 run on x86_64-linux 1

3 packages built:
  • dart (dart_stable)
  • dart_dev
  • dart_old

SuperSandro2000
SuperSandro2000 approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@ericdallo
Copy link
Member

This PR is outdated as dart is already updated

@ericdallo ericdallo closed this Jul 19, 2021
@Sorixelle Sorixelle deleted the dart-update branch July 20, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@ericdallo ericdallo ericdallo approved these changes

@GRBurst GRBurst Awaiting requested review from GRBurst

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sorixelle @ericdallo @jtacoma @SuperSandro2000