Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghcHEAD: 8.11.20200731 -> 8.11.20200824 #96125

Merged
merged 1 commit into from Aug 24, 2020
Merged

ghcHEAD: 8.11.20200731 -> 8.11.20200824 #96125

merged 1 commit into from Aug 24, 2020

Conversation

utdemir
Copy link
Member

@utdemir utdemir commented Aug 23, 2020

Motivation for this change

This commit updates ghcHEAD to the latest revision. I tried that both haskell.compiler.ghcHEAD and haskell.compiler.native-bignum.ghcHEAD, both can compile simple Haskell sources, as well as simple things like haskell.packages.ghcHEAD.base-compat.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@utdemir utdemir mentioned this pull request Aug 23, 2020
Closed
@ofborg ofborg bot requested review from kosmikus and peti August 24, 2020 00:34
@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskell.compiler.ghcHEAD
@GrahamcOfBorg build haskell.packages.ghcHEAD.base-compat
@GrahamcOfBorg build haskell.compiler.native-bignum.ghcHEAD
@GrahamcOfBorg build haskell.packages.native-bignum.ghcHEAD.base-compat

@cdepillabout
Copy link
Member

All the above packages appear to compile on x86_64 Linux, so this looks good to me!

@utdemir Thanks!

@cdepillabout cdepillabout merged commit 5f6fc2d into NixOS:haskell-updates Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@kosmikus kosmikus Awaiting requested review from kosmikus

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@utdemir @cdepillabout