Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmod: add patch to correct behaviour with --field #96123

Closed
wants to merge 1 commit into from
Closed

kmod: add patch to correct behaviour with --field #96123

wants to merge 1 commit into from

Conversation

xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Aug 23, 2020 •
edited by lheckemann

superseded by #96153

This came up in #96008.
Without this patch modinfo always prints the module name for builtin modules, even if an explicit --field is passed.

(I also posted this patch upstream, waiting for feedback there)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xaverdh
kmod: add patch to correct behaviour with --field
9306315 
This came up in NixOS#96008.
Without this patch modinfo always prints the module name for builtin
modules, even if an explicit --field is passed.
@baloo baloo mentioned this pull request Aug 23, 2020
Merged
10 tasks
@xaverdh
Copy link
Contributor Author

xaverdh commented Aug 24, 2020

ah maybe this should target staging?

@xaverdh xaverdh changed the base branch from master to staging August 24, 2020 08:47
@xaverdh xaverdh changed the base branch from staging to master August 24, 2020 08:48
@xaverdh xaverdh mentioned this pull request Aug 24, 2020
Merged
10 tasks
@FRidh
Copy link
Member

FRidh commented Aug 24, 2020

closing for #96153

@FRidh FRidh closed this Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@joachifm joachifm Awaiting requested review from joachifm

@jonringer jonringer Awaiting requested review from jonringer

@tfc tfc Awaiting requested review from tfc

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xaverdh @FRidh