gnomeExtensions.night-theme-switcher: 19 -> 36 #95950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: GNOME
bjornfor
reviewed
Aug 22, 2020
| mkdir -p $out/share/gnome-shell/extensions/ | ||
| cp -r src/ $out/share/gnome-shell/extensions/${uuid} | ||
| runHook postInstall |
There was a problem hiding this comment.
runHook should not be removed when the install phase is overridden, like ot is here.
jonafato
force-pushed
the
gnomeExtensions.night-theme-switcher-36
branch
from
3703055
to
de8caf3
Compare
jonafato
force-pushed
the
gnomeExtensions.night-theme-switcher-36
branch
from
de8caf3
to
a994d83
Compare
bjornfor
approved these changes
Aug 23, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The
night-theme-switcherGNOME Shell extension is outdated. There are a number of updates and new features in the changelog.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)