Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make optional properties return None while uninitialized. #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make optional properties return None while uninitialized. #26

wants to merge 1 commit into from

Conversation

jfng
Copy link
Member

@jfng jfng commented Aug 22, 2020

The previous behaviour was to raise a NotImplementedError. It is now the
responsibility of the caller to check if the property was initialized or
not.

Affected properties:

  • wishbone.Interface.memory_map
  • csr.Interface.memory_map
  • event.Source.event_map
  • periph.PeripheralInfo.irq

Make optional properties return None while uninitialized.
cf3412b 
The previous behaviour was to raise a NotImplementedError. It is now the
responsibility of the caller to check if the property was initialized or
not.

Affected properties:
* wishbone.Interface.memory_map
* csr.Interface.memory_map
* event.Source.event_map
* periph.PeripheralInfo.irq
@jfng
Copy link
Member Author

jfng commented Aug 22, 2020

Related to #19 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jfng