Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monoid: 2016-07-21 -> 2018-06-03, use python3 #99561

Merged
merged 1 commit into from Oct 4, 2020
Merged

monoid: 2016-07-21 -> 2018-06-03, use python3 #99561

merged 1 commit into from Oct 4, 2020

Conversation

erictapen
Copy link
Member

@erictapen erictapen commented Oct 4, 2020 •
edited

Motivation for this change

monoid is broken, as fontforge doesn't supply python2 bindings anymore.

Also address #98475.

Things done

Bumped version, applied larsenwork/monoid#233, use python3Packages.fontforge.

This needs to be backported to nixos-20.09. For nixos-20.03 see #99558.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also pinging @romildo as the maintainer of the package.

@erictapen
monoid: 2016-07-21 -> 2018-06-03
b6b8503 
Also applied a patch, so we can build with python3Packages.fontforge, as
fontforge doesn't have python2 bindings anymore.
@erictapen erictapen requested a review from romildo October 4, 2020 14:31
romildo
romildo approved these changes Oct 4, 2020
View reviewed changes
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erictapen erictapen merged commit 73eeb77 into NixOS:master Oct 4, 2020
@erictapen
Copy link
Member Author

backport to 20.09 in 77660fc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romildo romildo romildo approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erictapen @romildo