modify statedict: enable storing dict via json.dump #1410

lukebfox · 2020-10-04T15:29:09Z

attr_property has the ability to set state for attributes created with the "json" type with values of the list or dict type.

nixops/nixops/util.py

Lines 487 to 488 in a287225

    
           elif type == "json": 
        
               self._set_attr(name, json.dumps(x, cls=NixopsEncoder))

The diff engine uses the newer StateDict, which has it's own setter for state.

nixops/nixops/state.py

Lines 31 to 37 in 78a8815

    
           v = value 
        
           if isinstance(value, list): 
        
               v = json.dumps(value, cls=nixops.util.NixopsEncoder) 
        
           c.execute( 
        
               "insert or replace into ResourceAttrs(machine, name, value) values (?, ?, ?)", 
        
               (self.id, key, v), 
        
           )

The nixops-aws VPC resources which motivated the diff engine never had a dict case, so I guess it was left out, but it's important to keep this functionality for other resources which want to use the diff engine in the future (I am working on some).

…erty

modify statedict: enable storing dict via json.dump like in attr_prop…

9a89cd5

…erty

lukebfox mentioned this pull request Nov 27, 2020

Hetzner Cloud support NixOS/nixops-hetzner#35

Open

adisbladis merged commit faed063 into NixOS:master Nov 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

modify statedict: enable storing dict via json.dump #1410

modify statedict: enable storing dict via json.dump #1410

lukebfox commented Oct 4, 2020

	elif type == "json":
	self._set_attr(name, json.dumps(x, cls=NixopsEncoder))

	v = value
	if isinstance(value, list):
	v = json.dumps(value, cls=nixops.util.NixopsEncoder)
	c.execute(
	"insert or replace into ResourceAttrs(machine, name, value) values (?, ?, ?)",
	(self.id, key, v),
	)

modify statedict: enable storing dict via json.dump #1410

modify statedict: enable storing dict via json.dump #1410

Conversation

lukebfox commented Oct 4, 2020