Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pymc3: fix build, init pythonPackages.fastprogress at 1.0.0 #99587

Merged
merged 2 commits into from Oct 18, 2020
Merged

pythonPackages.pymc3: fix build, init pythonPackages.fastprogress at 1.0.0 #99587

merged 2 commits into from Oct 18, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 4, 2020 •
edited

Motivation for this change

ZHF: #97479

This has to wait on both:

Includes new dependency fastprogress.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor Author

risicle commented Oct 16, 2020 •
edited

@ofborg build python37Packages.pymc3

@risicle risicle marked this pull request as ready for review October 17, 2020 20:26
@risicle
Copy link
Contributor Author

risicle commented Oct 17, 2020

This is a fun situation - the issues holding up this PR have been resolved, but in that time, the dependency tensorflow has been broken in master. So testing this PR is difficult. But the reason I actually want it merged is because I need to backport it to 20.09, where it will be able to actually fix pymc3. I promise.

So, seeing as pymc3 was previously broken anyway, I wonder if anyone would find it in their hearts to "just trust me".

@risicle risicle mentioned this pull request Oct 17, 2020
Closed
@jonringer jonringer merged commit 3c3295a into NixOS:master Oct 18, 2020
@jonringer
Copy link
Contributor

i think it's fine. it's still an improvement, just because tensorflow likes to die every other week shouldn't keep this from also being backported

@risicle risicle mentioned this pull request Oct 18, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer