New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.wxPython: fix build on darwin #99586
Conversation
Yeah that is odd with the cflags. Also, why are those frameworks in nativeBuildInputs rather than buildInputs? macos 10.14: 7 packages marked as broken and skipped:
3 packages failed to build:
3 packages built:
|
🤷 🤷 🤷 🤷 🤷 🤷 🤷 🤷 🤷 🤷 🤷 🤷 I mean, it does seem to actually work with at least one downstream app ( |
@LnL7 what's the practice for darwin frameworks? I'm assuming the should be in buildInputs as they will likely need to be linked against. |
Indeed frameworks are just libraries with some extra stuff. Framework flags are also setup automatically, but that is most likely skipped because it's they are native inputs here. |
f3bc893
to
b8dc969
Compare
b8dc969
to
3382ea4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 99586 1
Motivation for this change
ZHF: #97479
I don't know why I have to do all the manual framework inclusion through
NIX_CFLAGS_COMPILE
- surely this should be done at a higher level. Perhaps someone with more macos nous can tell me how to do this more elegantly...Reverse dependency
plover
still fails to build.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)