Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lexicon: fix build, ape: fix inheritance #99571

Merged
merged 3 commits into from Oct 5, 2020
Merged

lexicon: fix build, ape: fix inheritance #99571

merged 3 commits into from Oct 5, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 4, 2020 •
edited

Motivation for this change

follow up to: #99568

created a python packages overlay for lexicon.
bumped lexicon

fixed ape from inheriting the lexicon attr from pkgs scope.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/99571
2 packages built:
ape lexicon

@jonringer
Copy link
Contributor Author

I ran ofborg checkMeta locally:

[09:06:42] jon@nixos ~/projects/nixpkgs (fix-lexicon)
$ GC_INITIAL_HEAP_SIZE=16g nix-env -f ./outpaths.nix -qaP --no-name --out-path --arg checkMeta true > out-paths
[09:09:37] jon@nixos ~/projects/nixpkgs (fix-lexicon)

NOTE: takes >=20GB of RAM to execute that now

@jonringer jonringer changed the title Fix lexicon lexicon: fix build, ape: fix inheritance Oct 4, 2020
@ofborg ofborg bot requested a review from yrashk October 4, 2020 19:22
@jonringer jonringer merged commit 90e5082 into NixOS:master Oct 5, 2020
@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 5, 2020
@jonringer jonringer deleted the fix-lexicon branch October 6, 2020 19:01
@jonringer jonringer added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrashk yrashk Awaiting requested review from yrashk

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer