Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsh: init at 0.7.2 #99565

Merged
merged 1 commit into from Jan 12, 2021
Merged

vsh: init at 0.7.2 #99565

merged 1 commit into from Jan 12, 2021

Conversation

fishi0x01
Copy link
Member

Motivation for this change

Add vsh tool

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit October 4, 2020 18:12
SuperSandro2000
SuperSandro2000 requested changes Nov 28, 2020
View reviewed changes
pkgs/tools/misc/vsh/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99565 run on x86_64-linux 1

1 package built:
  • vsh

SuperSandro2000
SuperSandro2000 requested changes Nov 28, 2020
View reviewed changes
pkgs/tools/misc/vsh/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99565 run on x86_64-darwin 1

1 package built:
  • vsh

SuperSandro2000
SuperSandro2000 requested changes Nov 28, 2020
View reviewed changes
pkgs/tools/misc/vsh/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/vsh/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 99565 run on x86_64-linux 1

1 package built:
  • vsh

@SuperSandro2000 SuperSandro2000 merged commit 1760d48 into NixOS:master Jan 12, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 99565 run on x86_64-darwin 1

1 package built:
  • vsh

@fishi0x01 fishi0x01 deleted the fishi0x01/vsh branch February 6, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fishi0x01 @SuperSandro2000